Some code cleanup(s) #7412
Merged
Some code cleanup(s) #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up player * Removed ``player.getPlayPauseButton().requestFocus();`` as there is no reason why it was introduced there documented * Use the same delay to hide the controls on both players
litetex
added
the
codequality
TobiGr
reviewed
Nov 16, 2021
app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java
Show resolved
Hide resolved
litetex
force-pushed
the
code-cleanup
branch
from
a372ba1 to
203ca9a
Compare
Stypox
requested changes
Nov 21, 2021
There was a problem hiding this comment.
I agree with you that removing the undocumented focus request is the right thing to do, then this is good to go (except for the small formatting issue). Btw the requestFocus line of code was added in a merge commit of #2907: https://github.com/TeamNewPipe/NewPipe/blame/3871d5aed77f63c74867b6076b31a61b69a8fda7/app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java#L370
app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java
Outdated
Show resolved
Hide resolved
litetex
commented
Nov 21, 2021
app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java
Outdated
Show resolved
Hide resolved
litetex
commented
Nov 21, 2021
app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java
Outdated
Show resolved
Hide resolved
|
Please review again. |
Stypox
requested changes
Nov 21, 2021
app/src/main/java/org/schabi/newpipe/player/event/PlayerGestureListener.java
Outdated
Show resolved
Hide resolved
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Code cleanup
See the commits for more detailed description.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence